Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilithium: fix minor errors #153

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

kojo1
Copy link
Contributor

@kojo1 kojo1 commented Oct 25, 2024

Some fixes on:
Add Dilithium to genkey, sign-verify and gen-sig-ver test #150

@kojo1 kojo1 force-pushed the dilithium branch 2 times, most recently from 417a655 to 35f91da Compare November 1, 2024 00:38
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are minor. I'd like to fix them in a follow up pull request that also expands the github actions for testing the build.

Thanks to both of you for the hard work on this!

src/genkey/clu_genkey_setup.c Show resolved Hide resolved
src/genkey/clu_genkey.c Show resolved Hide resolved
@JacobBarthelmeh JacobBarthelmeh merged commit 59b0884 into wolfSSL:main Nov 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants