Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wolfhsm updates #14

Merged
merged 15 commits into from
Aug 15, 2024
Merged

Wolfhsm updates #14

merged 15 commits into from
Aug 15, 2024

Conversation

bigbrett
Copy link
Contributor

@bigbrett bigbrett commented Aug 15, 2024

Pulls in some of the updates from #12 (which are needed), but with the following changes:

  • omits the user_settings.h modifications
  • omits inclusion of wolfSSL source code on the server side.
  • keeps test/bench demos, but turns them off by default, since tests don't pass

NOTE: This contains a hack in 85d2622 that zeros out the AES context to get it to work. Instead, this needs to be done in wh_Client_SetKeyIdAes() so that garbage doesn't fail the length check in wolfcrypt AES

Stopgap so we can get the changes in.

Copy link
Contributor

@billphipps billphipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stopgap. I'll merge now.

@billphipps billphipps merged commit 3e842b3 into wolfSSL:main Aug 15, 2024
1 check passed
@bigbrett
Copy link
Contributor Author

@billphipps awesome, thx. Buys us time until you can continue on #12 again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants