Curve25519 fixes #83
Merged
Curve25519 fixes #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed wolfCrypt tests are failing - didn't try that locally. I should turn that on by default. I'll investigate |
billphipps
requested changes
Nov 4, 2024
src/wh_crypto.c
Outdated
| @@ -36,6 +36,7 @@ | |||
| #include "wolfssl/wolfcrypt/types.h" | |||
| #include "wolfssl/wolfcrypt/error-crypt.h" | |||
| #include "wolfssl/wolfcrypt/asn.h" | |||
| #include "wolfssl/wolfcrypt/asn_public.h" | |||
There was a problem hiding this comment.
asn.h include asn_public.h. Were you getting a compile warning/error without asn_public.h explicitly included?
src/wh_crypto.c
Outdated
Comment on lines
212
to
225
| #ifdef HAVE_CURVE25519 | ||
| #ifdef HAVE_CURVE25519_KEY_IMPORT | ||
| WOLFSSL_API int wc_Curve25519PrivateKeyDecode( | ||
| const byte* input, word32* inOutIdx, curve25519_key* key, word32 inSz); | ||
| WOLFSSL_API int wc_Curve25519PublicKeyDecode( | ||
| const byte* input, word32* inOutIdx, curve25519_key* key, word32 inSz); | ||
| #endif | ||
| #ifdef HAVE_CURVE25519_KEY_EXPORT | ||
| WOLFSSL_API int wc_Curve25519PrivateKeyToDer( | ||
| curve25519_key* key, byte* output, word32 inLen); | ||
| WOLFSSL_API int wc_Curve25519PublicKeyToDer( | ||
| curve25519_key* key, byte* output, word32 inLen, int withAlg); | ||
| #endif | ||
| #endif /* HAVE_CURVE25519 */ |
There was a problem hiding this comment.
Aren't these already declared in asn_public.h?
There was a problem hiding this comment.
yep, this should have been removed. fixed
jefferyq2
pushed a commit
to jefferyq2/wolfHSM
that referenced
this pull request
Nov 10, 2024
Curve25519 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes curve25519 implementation, changing it to use new wolfCrypt DER API for ser/de instead of raw keys