Fix TSAN report with WOLFMQTT_DEBUG_CLIENT set around the use of clie…

…nt->lastRc used for debugging.
wolfSSL · Nov 21, 2023 · 052656c · 052656c
1 parent ebd7bab
commit 052656c
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/mqtt_client.c b/src/mqtt_client.c
@@ -1381,8 +1381,16 @@ static int MqttClient_WaitType(MqttClient *client, void *packet_obj,
 
 #ifdef WOLFMQTT_NONBLOCK
     #ifdef WOLFMQTT_DEBUG_CLIENT
-    client->lastRc = rc;
+    #ifdef WOLFMQTT_MULTITHREAD
+    if (wm_SemLock(&client->lockClient) == 0)
     #endif
+    {
+        client->lastRc = rc;
+    #ifdef WOLFMQTT_MULTITHREAD
+        wm_SemUnlock(&client->lockClient);
+    #endif
+    }
+    #endif /* WOLFMQTT_DEBUG_CLIENT */
     if (rc == MQTT_CODE_CONTINUE) {
         return rc;
     }