Fix for TLS v1.3 in non-blocking loosing return code from SendBuffered
#7001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed`. Example: SendBuffered returns WANT_WRITE (-327) and sets ssl->error, then below it was doing `ssl->error = ret` where ret = 0.
dgarske
changed the title
SendBuffered
JacobBarthelmeh
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for TLS v1.3 in non-blocking loosing return code from
SendBuffered.Example: SendBuffered returns WANT_WRITE (-327) and sets ssl->error, then below (11994) it was doing
ssl->error = retwhere ret = 0 and loosing the WANT_WRITE.Testing
Noticed with new non-blocking MQTT TLS tests in wolfSSL/wolfMQTT#373
This PR needs merged before MQTT PR will pass.
Checklist