Add Codespell test to PRs #8043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandi13
force-pushed
the
addCodespell
branch
9 times, most recently
from
3e9a8e1 to
4093930
Compare
embhorn
reviewed
Oct 7, 2024
philljj
requested changes
Oct 7, 2024
There was a problem hiding this comment.
nitpicky requests/suggestions:
-
We should skip files that throw codespell utf-8 warnings:
.csv,.der, any Japanese translation txt files, etc. -
Recommend merge squashing this to 1 commit.
-
Should we restrict this to code comments only for now? E.g. start with small experimental introduction of automated codespell.
douzzer
requested changes
Oct 8, 2024
4 tasks
bandi13
force-pushed
the
addCodespell
branch
2 times, most recently
from
9889ebe to
1e140a7
Compare
added 22 commits
November 1, 2024 12:59
|
Retest this please: PRB-known-configs.txt_70': FAIL: scripts/external |
dgarske
approved these changes
Nov 1, 2024
philljj
approved these changes
Nov 1, 2024
douzzer
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in a spell checker