Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverity errors #8085

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix coverity errors #8085

merged 3 commits into from
Oct 16, 2024

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Oct 16, 2024

Description

Fix miscellaneous things:

  • check return value of mp_sub_d in wolfcrypt test.c
  • check tmp != NULL before dereferencing in src ssl_asn1.c. tmp is assigned from buf, but then later buf pointer is potentially altered, making it unclear if tmp is guaranteed to != NULL (hence adding explicit check).
  • fix potential double free or deref of freed encryptedContent in wolfcrypt pkcs7.c

Testing

Coverity scan.

@philljj philljj self-assigned this Oct 16, 2024
@philljj philljj assigned wolfSSL-Bot and unassigned philljj Oct 16, 2024
@douzzer douzzer merged commit 8803f3d into wolfSSL:master Oct 16, 2024
140 checks passed
@philljj philljj deleted the fix_coverity branch October 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants