Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for state of aes.gcm.H on re-use #8107

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

JacobBarthelmeh
Copy link
Contributor

Discovered on Windows build and benchmark. Can be reproduced on Linux with

./configure --enable-aesgcm-stream --enable-aesgcm=large && make && ./wolfcrypt/benchmark/benchmark -aes-gcm

------------------------------------------------------------------------------
 wolfSSL version 5.7.2
------------------------------------------------------------------------------
Math: 	Multi-Precision: Wolf(SP) word-size=64 bits=4096 sp_int.c
wolfCrypt Benchmark (block bytes 1048576, min 1.0 sec each)
AES-128-GCM-enc             90 MiB took 1.045 seconds,   86.146 MiB/s Cycles per byte =  40.96
AES-128-GCM-dec             90 MiB took 1.042 seconds,   86.411 MiB/s Cycles per byte =  40.83
AES-192-GCM-enc             85 MiB took 1.018 seconds,   83.510 MiB/s Cycles per byte =  42.25
AES-192-GCM-dec             85 MiB took 1.027 seconds,   82.795 MiB/s Cycles per byte =  42.62
AES-256-GCM-enc             85 MiB took 1.058 seconds,   80.376 MiB/s Cycles per byte =  43.90
AES-256-GCM-dec             85 MiB took 1.059 seconds,   80.246 MiB/s Cycles per byte =  43.97
AES-128-GCM-STREAM-enc      90 MiB took 1.041 seconds,   86.443 MiB/s Cycles per byte =  40.82
AES-128-GCM-STREAM-dec       0 bytes took 0.012 seconds,    0.000 bytes/s Cycles per byte =   0.00
Benchmark AES-128-GCM-STREAM-dec failed: -180
bench_aesgcm failed: -180
AES-192-GCM-STREAM-enc      85 MiB took 1.017 seconds,   83.550 MiB/s Cycles per byte =  42.23
AES-192-GCM-STREAM-dec       0 bytes took 0.012 seconds,    0.000 bytes/s Cycles per byte =   0.00
Benchmark AES-192-GCM-STREAM-dec failed: -180
bench_aesgcm failed: -180
AES-256-GCM-STREAM-enc      80 MiB took 1.002 seconds,   79.860 MiB/s Cycles per byte =  44.18
AES-256-GCM-STREAM-dec       0 bytes took 0.012 seconds,    0.000 bytes/s Cycles per byte =   0.00
Benchmark AES-256-GCM-STREAM-dec failed: -180
bench_aesgcm failed: -180
GMAC Default               116 MiB took 1.001 seconds,  115.857 MiB/s Cycles per byte =  30.46
Benchmark complete

@JacobBarthelmeh JacobBarthelmeh self-assigned this Oct 23, 2024
@douzzer douzzer merged commit 8227309 into wolfSSL:master Oct 23, 2024
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants