Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TLS v1.2 session resumption with tickets where the server decides to do full handshake #8108

Closed
wants to merge 1 commit into from

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Oct 23, 2024

Description

Fix for TLS v1.2 session resumption with tickets where the server decides to do a full handshake. The wrong sessionIDSz was being checked and should be the arrays one since it get set from the server_hello.

Fixes ZD 18822

Testing

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Oct 23, 2024
@dgarske dgarske requested a review from julek-wolfssl October 23, 2024 21:58
julek-wolfssl
julek-wolfssl previously approved these changes Oct 23, 2024
src/internal.c Show resolved Hide resolved
…ides to do a full handshake. The wrong sessionIDSz was being checked and should be the arrays one since it get set from the server_hello.
@dgarske
Copy link
Contributor Author

dgarske commented Oct 23, 2024

Applied commit on top of #8097. That also resolves an issue with the server_hello session id being populated when it should not. Resolves the 964: test_session_ticket_no_id issue.

@dgarske dgarske closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants