memory: fix types in wc_LoadStaticMemory_ex() #8117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
JacobBarthelmeh
requested changes
Oct 30, 2024
There was a problem hiding this comment.
There's a few more locations that need touched to make all sizeList and distList be an array of word32's
- wolfssl/wolfcrypt/memory.h, line 222
- wolfssl/wolfcrypt/memory.h, line 260
- wolfssl/wolfcrypt/memory.h, line 284
- wolfcrypt/src/memory.c, line 672
- wolfcrypt/src/memory.c, line 820
rizlik
force-pushed
the
static_mem_fix_types
branch
from
48b36da to
dce9b2e
Compare
completely missed them. Thanks |
|
Retest this please Jenkins. I missed capturing what the failure was. |
JacobBarthelmeh
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to use the right array type in wc_LoadStaticMemory_ex()