-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Raspberry Pi Pico #8153
Conversation
Can one of the admins verify this patch? |
Okay to test |
@@ -0,0 +1,70 @@ | |||
/* pico.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a README.md for this port and any tips for building / testing.
Please add the new files pico.c and pico.h to the include.am EXTRA_DIST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. Both items should now be addressed. I've moved the large comment from pico.c
into the README.md too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the .c and .h. Please also include the README.md in EXTRA_DIST, otherwise it will not be included in the "make dist" done for release packaging.
Rebased off master to resolve conflicts. |
@@ -0,0 +1,70 @@ | |||
/* pico.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the .c and .h. Please also include the README.md in EXTRA_DIST, otherwise it will not be included in the "make dist" done for release packaging.
|
||
## Comiling wolfSSL | ||
|
||
In `settings.c` you should uncomment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
settings.h
?. We typically don't recommend this approach. Recommendation is WOLFSSL_USER_SETTINGS and user_settings.h. The reason is making changes to settings.h causes issue with new software updates.
) | ||
``` | ||
|
||
A full example can be found in the `RPi-Pico` directory of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider a direct link to https://github.com/wolfSSL/wolfssl-examples/tree/master/RPi-Pico
Last review round of problems should now be addressed. Many thanks! |
This adds improved support for the Raspberry Pi Pico range of microcontrollers. Benchmark now compiles, and added support for the RNG functions of the Pico SDK. This gives a ~2x RNG performance improvement on the RP2040 and over 3x improvement on the RP2350. The accelerated SHA256 in the RP2350 unfortunately cannot be used with wolfSSL.
Typo found by Codespell addressed. |
Okay to test. |
Description
This adds improved support for the Raspberry Pi Pico range of microcontrollers.
Benchmark now compiles, and added support for the RNG functions of the Pico SDK. This gives a ~2x RNG performance improvement on the RP2040 and over 3x improvement on the RP2350.
The accelerated SHA256 in the RP2350 unfortunately cannot be used with wolfSSL.
Testing
WolfSSL-examples PR coming shortly which runs tests and benchmark.
Checklist