Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for memory issue due to missed WOLFSSL_GENERAL_NAME capability cha… #8155

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

JacobBarthelmeh
Copy link
Contributor

…nges

Reproduced when testing a wolfCLU unit test with -fsanitize=address.

@JacobBarthelmeh
Copy link
Contributor Author

Re-testing mosquitto Tests / 2.0.18. Looks like a time out:

1474 tests total
1474 tests succeeded
./test.py
Error: The operation was canceled.

Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ warning needs a fix (cast the ret from XMALLOC):

./src/x509.c: In function ‘int DNS_to_GENERAL_NAME(WOLFSSL_GENERAL_NAME*, DNS_entry*)’:
9386a882b9 (<[email protected]> 2021-10-19 15:51:29 +0200 594)                 #define XMALLOC(s, h, t)     ((void)(h), (void)(t), wolfSSL_Malloc((s)))
./wolfssl/wolfcrypt/types.h:594:67: error: invalid conversion from ‘void*’ to ‘const unsigned char*’ [-fpermissive]
  594 |                 #define XMALLOC(s, h, t)     ((void)(h), (void)(t), wolfSSL_Malloc((s)))
      |                                              ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
      |                                                                   |
      |                                                                   void*
5647f5c82f (<[email protected]> 2024-11-06 17:10:54 -0700 634)             gn->d.registeredID->obj = XMALLOC(dns->len,

@douzzer douzzer merged commit 878cf3a into wolfSSL:master Nov 12, 2024
143 checks passed
@JacobBarthelmeh JacobBarthelmeh changed the title fix for memory leak due to missed WOLFSSL_GENERAL_NAME capability cha… fix for memory issue due to missed WOLFSSL_GENERAL_NAME capability cha… Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants