gcc-4.0.x does not have __sync_synchronize() to be used for XFENCE #8163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wc_port.h expects __sync_synchronize() in gcc-4.x, but it was introduced since gcc-4.1.0. https://github.com/gcc-mirror/gcc/blob/releases/gcc-4.0/gcc/builtins.def https://github.com/gcc-mirror/gcc/blob/releases/gcc-4.1.0/gcc/builtins.def It would be safer to deal gcc-4.0 as gcc-3.x or older one.
|
Can one of the admins verify this patch? |
|
Okay to test. Contributor agreement on file. |
|
Oh, what? During the check, a building test on latest macOS is reported as failed. I would try to reproduce the error in my environment... |
|
retest this please. |
|
retest this please |
|
Retest this please. History lost for failed PRB test. |
|
@mpsuzuki Can you please rebase to latest master? Getting a failure on |
Merged
|
I apologize that I failed to rebase my patch timely, anyway, thank you for caring about the ancient gcc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wc_port.h expects __sync_synchronize() in gcc-4.x, but it was introduced since gcc-4.1.0.
Please find the end of gcc/builtins.def in gcc-4.0 branch and gcc-4.1.0 (sorry, the changeset between gcc-4.0.4 and gcc-4.1.0 is too huge for github.com's comparison feature to display well).
gcc-4.0.x gcc/builtins.def
gcc-4.1.0 gcc/builtins.def
It would be safer to deal gcc-4.0 as gcc-3.x or older one.
Description
To build wolfSSL by ancient gcc on ancient platform, the C preprocessor-based function availability classification is improved.
Testing
Building wolfSSL with gcc-4.0.0 (on FreeBSD 5.5) finishes. Without this modification, the built libwolfssl.so would have an unresolvable reference to __sync_synchronize(), and it makes the linking of wolfcrypt/benchmark/benchmark failed as
Checklist