-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize vars & change types to appease Windows/VS #8181
Conversation
7791535
to
028195d
Compare
2ad9df3
to
8e4cc38
Compare
Jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanups and extra checks. Passes my review and testing. Over to @SparkiDev to finalize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good! Had a few nits and a question or two.
8e4cc38
to
2f04bf0
Compare
2f04bf0
to
5d86031
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all landed in a good place. Thanks @gojimmypi !
Description
Addresses these warnings encountered during a Windows / Visual Studio build:
#define WOLFSSL_MAX_8BIT 0xffU
intype.h
warning C4141: 'dllexport': used more than once
, noted above.Fixes zd# n/a
Testing
Confirmed working with benchmark and test apps.
Checklist