-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/dev/crypto auth error fix/adjustment for benchmark #8210
/dev/crypto auth error fix/adjustment for benchmark #8210
Conversation
64129b7
to
eebd121
Compare
Retest this please - Python test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like sysconf is in QNX too (another system which has /dev/crypto) which is good, so seems portable enough for a call wrapped with the debug macro guard. Assign to wolfssl-bot when ready for a final review and potential merge into master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Please resolve this warning though:
CC examples/server/examples_server_server-server.o
wolfcrypt/benchmark/benchmark.c: In function ‘bench_gmac’:
wolfcrypt/benchmark/benchmark.c:4846:71: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ [-Wformat=]
printf("authIn Buffer Size[%d] greater than System Page Size[%d]\n",
~^
%ld
bench_size, sysconf(_SC_PAGESIZE));
~~~~~~~~~~~~~~~~~~~~~
CC examples/pem/pem.o
7dc7887
to
02e6ec0
Compare
Fixed to resolve warning with benchmark, and squashed. |
Retest this please |
When configuring wolfSSL to use
/dev/crypto
and running our benchmark tool, GMAC benchmarks will throw the-265
error code after calling this line.This is because is due to this line in
/dev/crypto
driver.This PR adds better debugging and will set size when running GMAC to that of the system's page size. It also allows for an override for this size by setting the macro
WOLFSSL_AUTHSZ_BENCH