Improve Espressif SHA HW/SW mutex messages #8225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins retest this please |
gojimmypi
force-pushed
the
pr-espressif-improve-sha-msg
branch
from
54b3896 to
7bc0265
Compare
|
recent force-push: refreshed from upstream, corrected spelling. |
|
Jenkins retest this please |
JacobBarthelmeh
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves some of the debugging messages for hardware-accelerated SHA calculations on the Espressif ESP32.
Currently there are messages such as:
Although accurate, the condition is merely interesting, not actually an error. This typically occurs when there are multiple, concurrent hash calculations in progress, such as during TLS handshake negotiation. The unused hash values are abandoned, and although the hardware is released during cleanup, it is not the normal process of actually finishing up a SHA calculation.
There's also this one, that is also merely interesting:
In this case, the message likely occurred when using a
ctxobject across multiple threads, as operation are not thread-safe. It is up to the developer to handle any cross-thread operations.A variety of other messages and mutex-related SHA issues have also been updated.
Fixes zd# 19003
Testing
Manually tested with various configurations using the Espessif client and server examples.
Checklist
edit: reference zd 19003 and note manual testing.