Add STM32MP13 HAL support for more SHA types #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds STM32 HAL support for: * SHA384 * SHA512 (with -224 and -256) * SHA3 (all variants apart from SHAKE) The partial FIFO block calculations have been adjusted based in the STM32 code to support the larger hash sizes. This should work with other chips such as the STM32U5xx, but is not enabled for that yet.
|
SHAKE hardware acceleration is also possible if we need it. |
dgarske
reviewed
Nov 27, 2024
dgarske
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Thank you @LinuxJedi
Tested successfully on STM32U585, STM32U5A9 and STM32H7.
Also pushed a small issue with wolfssl_examples.c broken from a previous PR.
|
Thanks for running those tests. I have some STM32Fs here if you want me to run additional tests, but I don't envisage them being different. Good catch on your commit. |
dgarske
approved these changes
Nov 29, 2024
dgarske
approved these changes
Nov 29, 2024
|
@wolfSSL-Bot this PR is ready for merge but it needs an additional reviewer. |
JacobBarthelmeh
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds STM32 HAL support for:
The partial FIFO block calculations have been adjusted based in the STM32 code to support the larger hash sizes.
This should work with other chips such as the STM32U5xx, but is not enabled for that yet.
Testing
Tested using the wolfCrypt test suite and benchmark suite on an STM32MP135F-DK.
Checklist