wc_port: change zephyr struct k_thread tid member to pointer.#8236
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Dec 5, 2024
Merged
wc_port: change zephyr struct k_thread tid member to pointer.#8236JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
Author
|
retest this please. |
JacobBarthelmeh
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Zephyr THREAD_TYPE struct k_thread tid member to be pointer rather than value. Less intrusive alternative to #8234.
Fixes coverity PASS_BY_VALUE issue in zd#17705.
The struct
struct k_thread {(defined here) is potentially large and shouldn't be passed by value.Testing
Tested with: