Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Aarch64: make code compile when no hardware crypto avail" #8290

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Dec 13, 2024

Reverts #8277
I spent too much time trying to figure out a nice way to solve this...
@SparkiDev please revisit this PR.
This breaks several armv7a / aarch32 builds:

  • Multiple definitions of wc_AesSetKey, wc_AesSetIV, wc_AesGcmSetKey, etc...
  • Also incorrect definition for GMULT.

@dgarske
Copy link
Contributor Author

dgarske commented Dec 13, 2024

Retest this please. Seems a server went down?

Cannot contact boz-xeon3: java.io.IOException: Broken pipe
wrapper script does not seem to be touching the log file in /var/lib/jenkins/workspace/PRB-external-test@tmp/durable-9c1e9b92
(JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)
script returned exit code -1

@dgarske
Copy link
Contributor Author

dgarske commented Dec 14, 2024

FIPS tests for "PRB-fips-repo-and-harness-test-v3-part2" seem to dislike upstream revert....

+ ./tests/install-scripts/setup_environment-PRB.sh dgarske revert-8277-aarch64_no_crypto 140-2
Cloning into 'wolfssl'...
fatal: couldn't find remote ref revert-8277-aarch64_no_crypto
script returned exit code 1

@douzzer you are welcome to forcefully merge.

Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests OK post-revert:

[quantum-safe-wolfssl-all-cross-armv7a-armasm-unittest] [1 of 1] [71325a2a32]
    using armv7a-unknown-linux-gnueabihf-gcc 12.4.1
    autogen.sh 71325a2a32...   real 0m16.641s  user 0m14.741s  sys 0m1.003s
    configure...   real 0m12.655s  user 0m4.775s  sys 0m9.142s
    build.../usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld: warning: creating DT_TEXTREL in a shared object
   real 0m49.931s  user 2m43.427s  sys 0m10.534s
    unit.test...   real 3m12.485s  user 3m22.083s  sys 0m5.334s
    quantum-safe-wolfssl-all-cross-armv7a-armasm-unittest OK

@douzzer douzzer merged commit 4bdccac into master Dec 14, 2024
144 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants