Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64: make code compile when no hardware crypto avail #8293

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

SparkiDev
Copy link
Contributor

@SparkiDev SparkiDev commented Dec 16, 2024

Description

Detects availability of instructions for Aarch64.

Testing

With and without WOLFSSL_ARMASM_NO_HW_CRYPTO

./configure --enable-armasm CFLAGS="-DWOLFSSL_ARMASM_NO_HW_CRYPTO" && make check

Regression tested Aarch64, ARMv8 and ARMv7a with ARM assembly.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Dec 16, 2024
Detects availability of instructions for Aarch64.
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev assigned douzzer and wolfSSL-Bot and unassigned SparkiDev Dec 16, 2024
@dgarske dgarske self-requested a review December 16, 2024 16:16
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pi4, Pi5 and STM32MP1. Thank you @SparkiDev . Over to @douzzer

Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with wolfssl-multi-test.sh ... check-source-text quantum-safe-wolfssl-all-cross-armv7a-armasm-unittest quantum-safe-wolfssl-all-cross-aarch64-armasm-unittest-Os

@douzzer douzzer merged commit fd22bfc into wolfSSL:master Dec 16, 2024
145 checks passed
douzzer added a commit to douzzer/wolfssl that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants