Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert beego bump in harbor-2.11 #26370

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Revert beego bump in harbor-2.11 #26370

merged 3 commits into from
Aug 15, 2024

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Aug 15, 2024

@EyeCantCU reverted this in #26137 but then our automation added it back in (#26157). I think it's breaking the harbor helm test which is causing https://github.com/chainguard-dev/image-release-stats/issues/280 (cc @smoser)

I added manual: true for now but please let me know if there's a better way to stop automation from adding this back in

EyeCantCU
EyeCantCU previously approved these changes Aug 15, 2024
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@ajayk
Copy link
Contributor

ajayk commented Aug 15, 2024

You need to bump the epoch as well

@EyeCantCU
Copy link
Member

Just to add, unfortunately I don't believe there's a way. I filed advisories but automation still tries to remediate the CVE

@ajayk
Copy link
Contributor

ajayk commented Aug 15, 2024

and manual: true is for updates not cve fixes , we can put the CVE fix in the draft whenever we get so it will not update it

@priyawadhwa
Copy link
Contributor Author

Sounds good, will keep an eye out for the automation PR and put it in draft. Thank you @ajayk & @EyeCantCU!

@ajayk ajayk enabled auto-merge (squash) August 15, 2024 03:12
@ajayk ajayk merged commit 742b22b into wolfi-dev:main Aug 15, 2024
9 of 10 checks passed
@priyawadhwa priyawadhwa deleted the beego branch August 15, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants