Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buck2: Remove uneeded llvm dep #30338

Merged
merged 1 commit into from
Oct 8, 2024
Merged

buck2: Remove uneeded llvm dep #30338

merged 1 commit into from
Oct 8, 2024

Conversation

justinvreeland
Copy link
Contributor

@justinvreeland justinvreeland marked this pull request as ready for review October 8, 2024 18:25
xnox
xnox requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@xnox xnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to melange file; that affect buildability require epoch bump.

we want to verify that this change does indeed still builds.

@justinvreeland
Copy link
Contributor Author

we want to verify that this change does indeed still builds.
Ahh ok, I was going with the assumption that if it built in CI it was fine since this won't change the deps of the binary package.

@xnox xnox enabled auto-merge (squash) October 8, 2024 20:08
@xnox xnox merged commit b886d68 into wolfi-dev:main Oct 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnox xnox xnox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinvreeland @xnox