wolfictl pmub: just a reverse of wolfictl bump #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if this was just a flag on |
ajayk
force-pushed
the
reverse-bump
branch
7 times, most recently
from
4d4e400
to
1724442
Compare
|
@jonjohnsonjr PTAL |
| @@ -120,6 +129,7 @@ modifying anything in the filesystem. | |||
| cmd.Flags().BoolVar(&opts.epoch, "epoch", true, "bump the package epoch") | |||
| cmd.Flags().BoolVar(&opts.dryRun, "dry-run", false, "don't change anything, just print what would be done") | |||
| cmd.Flags().StringVar(&opts.repoDir, "repo", ".", "path to the wolfi/os repository") | |||
| cmd.Flags().BoolVar(&opts.increment, "increment", true, "increments/decrements the package epoch") | |||
There was a problem hiding this comment.
Would we ever want to bump by anything other than -1 and +1? Would it make sense to have this take an int flag that defaults to 1?
E.g. to bump down, do this:
wolfictl bump --by -1 foo.yaml
If not, then I think I'd prefer this be a negative flag (--decrement or --substract or --minus or --undo) that defaults to false because it's easier to type:
wolfictl bump --undo
Than it is to type:
wolfictl bump --increment=false
But also because I just learned that this would be an error:
wolfictl bump --increment false
(See wolfi-dev/os@bfe82af 🤦)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.