GOOWOO-759: Clear connection error slots and improve creation handling#3523
Open
asvinb wants to merge 2 commits into
Open
GOOWOO-759: Clear connection error slots and improve creation handling#3523asvinb wants to merge 2 commits into
asvinb wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3523 +/- ##
=========================================
+ Coverage 64.1% 64.3% +0.2%
=========================================
Files 395 395
Lines 6773 6785 +12
Branches 1720 1721 +1
=========================================
+ Hits 4342 4360 +18
+ Misses 2170 2166 -4
+ Partials 261 259 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/GOOWOO-759/account-creation-limit-reached-error-not-surfaced-to-merchants
Replace this with a good description of your changes & reasoning.
Screenshots:
Detailed test instructions:
/wp-json/wc/gla/ads/accounts[POST] endpoint with the mocked data below with the status code set to406/wp-json/wc/gla/ads/accounts[POST] with the payload consisting ofid.{"id":<xxx>}where is Google Ads Id you want to connect. Status code is403Sample mocked data:
Additional details:
Changelog entry