Notifications System#3590
Open
jamesmorrison wants to merge 323 commits into
Open
Conversation
Setting up notifications architecture.
…ister-gla-notification # Conflicts: # js/src/notifications-system/woo-marketing-notifications-slot/index.js
…ister-gla-notification # Conflicts: # js/src/notifications-system/woo-marketing-notifications-slot/constants.js # js/src/notifications-system/woo-marketing-notifications-slot/index.js
GOOWOO-738 add plugin agnostic notification system slot
…ter-gla-notification
…/google-listings-and-ads into feature/notifications-system
…entralize re-submission expiry logic
…ust batch sync logic
…th `batch_async`, add sub-response handling tests, and ensure proper indexing and failure identification
…sts and sub-response parsing
…rs, connection issues, and retry limitations
…, forced resync, and freshness logic behaviors
… control, and sync hash logic, covering transient errors, rate-limited responses, and connection issues
…ture/GOOWOO-786-auto-product-sync
…eferrer attribution
…e-merchant-api-to-notifications-system [GOOWOO-782] Integrate Merchant API to Notifications System - merge notifications [#3]
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/mapi-migration #3590 +/- ##
==========================================================
+ Coverage 67.9% 68.4% +0.5%
- Complexity 5709 5986 +277
==========================================================
Files 934 964 +30
Lines 29365 30323 +958
Branches 1721 1740 +19
==========================================================
+ Hits 19925 20735 +810
- Misses 9179 9326 +147
- Partials 261 262 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…P version in batch requests, and add error logging for unparsable batch responses
…leServiceProvider`
…oduct_inputs` docblock
…ndling on the full handler stack
…aign-bug Fix Bug for Skipped Campaign Signal Detection
…duct-sync GOOWOO-786: MAPI product sync
GOOWOO-677: Add Tracking to Notifications System
The marketing notifications slot and system bundles were only enqueued when the server detected page=wc-admin&path=/marketing. SPA navigations never trigger a full reload, so arriving at Marketing overview from another wc-admin route left the bundles absent. PHP: swap server-side path check for PageController::is_admin_page() so both bundles are available on every wc-admin page. JS: gate initNotifications() behind a getPath() check at load time and re-run on every SPA route change via getHistory().listen(). A module-level hasInitialized flag prevents duplicate registration on repeat visits.
…ding Prior commit widened asset loading from specific wc-admin paths to any wc-admin page. Update test names/assertions to match: enqueue on any wc-admin path, skip only outside wc-admin.
- Wrap "Terms apply." text with real link to Google Ads incentives terms via createInterpolateElement, tracked per notification. - Route "Continue Setup" action to onboardingUrl instead of unused getGetStartedUrl (GOOWOO-812). - Remove underline from notification title links.
fix(notifications): load notification bundles on all wc-admin pages for SPA nav
fix(notifications): link Terms apply text and fix onboarding URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes # .
Replace this with a good description of your changes & reasoning.
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry