Skip to content

Notifications System#3590

Open
jamesmorrison wants to merge 323 commits into
feature/mapi-migrationfrom
feature/notifications-system
Open

Notifications System#3590
jamesmorrison wants to merge 323 commits into
feature/mapi-migrationfrom
feature/notifications-system

Conversation

@jamesmorrison

Copy link
Copy Markdown
Collaborator

Changes proposed in this Pull Request:

Closes # .

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

Maggie Serino and others added 30 commits June 12, 2026 14:58
…ister-gla-notification

# Conflicts:
#	js/src/notifications-system/woo-marketing-notifications-slot/index.js
…ister-gla-notification

# Conflicts:
#	js/src/notifications-system/woo-marketing-notifications-slot/constants.js
#	js/src/notifications-system/woo-marketing-notifications-slot/index.js
…/google-listings-and-ads into feature/notifications-system
alaca and others added 11 commits July 13, 2026 14:55
…th `batch_async`, add sub-response handling tests, and ensure proper indexing and failure identification
…rs, connection issues, and retry limitations
…, forced resync, and freshness logic behaviors
… control, and sync hash logic, covering transient errors, rate-limited responses, and connection issues
…e-merchant-api-to-notifications-system

[GOOWOO-782] Integrate Merchant API to Notifications System - merge notifications [#3]
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.54764% with 174 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.4%. Comparing base (14a52b4) to head (3d9869a).
⚠️ Report is 32 commits behind head on feature/mapi-migration.

Files with missing lines Patch % Lines
...tification/Evaluators/SalesNotGrowingEvaluator.php 34.3% 44 Missing ⚠️
...ification/Evaluators/CouponsNotSyncedEvaluator.php 54.2% 22 Missing ⚠️
...rc/API/Site/Controllers/NotificationController.php 76.2% 19 Missing ⚠️
...endencyManagement/NotificationsServiceProvider.php 0.0% 15 Missing ⚠️
src/API/Google/Mapi/MerchantApiClient.php 81.0% 11 Missing ⚠️
...tification/Evaluators/ReadyButNoSalesEvaluator.php 66.7% 9 Missing ⚠️
js/src/data/actions.js 0.0% 8 Missing ⚠️
js/src/data/resolvers.js 14.3% 5 Missing and 1 partial ⚠️
...tification/Evaluators/CampaignNoSalesEvaluator.php 88.1% 5 Missing ⚠️
...c/Notification/Evaluators/Sold10ItemsEvaluator.php 87.2% 5 Missing ⚠️
... and 12 more
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##             feature/mapi-migration   #3590     +/-   ##
==========================================================
+ Coverage                      67.9%   68.4%   +0.5%     
- Complexity                     5709    5986    +277     
==========================================================
  Files                           934     964     +30     
  Lines                         29365   30323    +958     
  Branches                       1721    1740     +19     
==========================================================
+ Hits                          19925   20735    +810     
- Misses                         9179    9326    +147     
- Partials                        261     262      +1     
Flag Coverage Δ
js-unit-tests 64.4% <80.9%> (+0.3%) ⬆️
php-unit-tests 69.5% <82.8%> (+0.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/constants.js 100.0% <100.0%> (ø)
js/src/data/action-types.js 100.0% <ø> (ø)
js/src/data/reducer.js 69.4% <100.0%> (+0.7%) ⬆️
js/src/data/selectors.js 53.3% <100.0%> (+0.6%) ⬆️
...tions-slot/components/notifications-panel/index.js 100.0% <100.0%> (ø)
...stem/woo-marketing-notifications-slot/constants.js 100.0% <100.0%> (ø)
...woo-marketing-notifications-slot/data/constants.js 100.0% <100.0%> (ø)
...eting-notifications-slot/hooks/useNotifications.js 100.0% <100.0%> (ø)
js/src/utils/tracks.js 79.5% <100.0%> (+1.7%) ⬆️
.../Google/Mapi/Services/MapiProductInputsService.php 100.0% <100.0%> (ø)
... and 43 more

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamesmorrison
jamesmorrison changed the base branch from develop to feature/mapi-migration July 14, 2026 09:32
asvinb and others added 17 commits July 15, 2026 15:48
…P version in batch requests, and add error logging for unparsable batch responses
…aign-bug

Fix Bug for Skipped Campaign Signal Detection
The marketing notifications slot and system bundles were only enqueued
when the server detected page=wc-admin&path=/marketing. SPA navigations
never trigger a full reload, so arriving at Marketing overview from
another wc-admin route left the bundles absent.

PHP: swap server-side path check for PageController::is_admin_page() so
both bundles are available on every wc-admin page.

JS: gate initNotifications() behind a getPath() check at load time and
re-run on every SPA route change via getHistory().listen(). A module-level
hasInitialized flag prevents duplicate registration on repeat visits.
…ding

Prior commit widened asset loading from specific wc-admin paths to
any wc-admin page. Update test names/assertions to match: enqueue
on any wc-admin path, skip only outside wc-admin.
- Wrap "Terms apply." text with real link to Google Ads incentives
  terms via createInterpolateElement, tracked per notification.
- Route "Continue Setup" action to onboardingUrl instead of unused
  getGetStartedUrl (GOOWOO-812).
- Remove underline from notification title links.
fix(notifications): load notification bundles on all wc-admin pages for SPA nav
fix(notifications): link Terms apply text and fix onboarding URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants