Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the plugin doesn't have issues when released on WordPress.org #437

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dkotter
Copy link
Contributor

@dkotter dkotter commented Jun 3, 2024

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

During the last release to WordPress.org, two issues were encountered. Those were fixed directly in the codebase that gets deployed to WordPress.org so bringing those changes over to this repo:

  1. Ensure we have a proper plugin name in the readme.txt file. This has been set for 9+ years so not sure why it's causing an issue now but it's a good thing to fix anyway
  2. Remove woocommerce-bookings from the list of Required Plugins. Bookings is required but because Bookings isn't hosted on WordPress.org, it's been noted that this can cause problems (see https://make.wordpress.org/core/2024/03/05/introducing-plugin-dependencies-in-wordpress-6-5/)

Steps to test the changes in this Pull Request:

Nothing really needed to test here

Changelog entry

Dev - Add proper plugin name to the readme.txt. Remove Bookings from our required plugins list as it's not hosted on WordPress.org.

@dkotter dkotter added this to the 1.2.7 milestone Jun 3, 2024
@dkotter dkotter self-assigned this Jun 3, 2024
@dkotter dkotter requested a review from faisal-alvi June 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants