This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Import createElement to fix build issues with SlotFill #7403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwie17
approved these changes
Jul 22, 2021
joshuatf
force-pushed
the
fix/payment-gateway-slot-fill
branch
from
1e5389e to
5746d80
Compare
joshuatf
force-pushed
the
fix/payment-gateway-slot-fill
branch
from
5746d80 to
e73bee7
Compare
octaedro
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Import createElement to fix build issues with SlotFill * Add changelog entry
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
…oocommerce-admin#7403) * Import createElement to fix build issues with SlotFill * Add changelog entry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7402
Fixes the SlotFill due to a broken webpack build. Resolved by manually importing
createElement.Huge shoutout to @louwie17 for getting to the bottom of this.
Screenshots
Detailed test instructions:
yarn linkinsidepackages/onboardingin WooCommerce Admin.modules/ppcp-onboardingfolder in PayPal, runyarn link @woocommerce/onboarding && yarn build