Initialize privacy exporters on init
hook.
#325
Draft
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Relocates the initialization of the privacy export class from the
plugin_loaded
hook to thewoocommerce_init
hook, which fires on the WordPressinit
hook.This is to prevent WordPress throwing a notice due to the early calling of
_load_textdomain_just_in_time
via the privacy constructor.Note
The plugin uses the domain
woocommerce-gateway-payfast
while the slug on WordPress.org iswoocommerce-payfast-gateway
. For the time being this is preventing the removal of theload_plugin_textdomain
call.In order to remove it, the domain will need to be updated to match the wp.org plugin slug. See the i18n docs.
Closes https://linear.app/a8c/issue/PAYFAST-38/php-notice-function-load-textdomain-just-in-time-was-called
Steps to test the changes in this Pull Request:
Changelog entry