Initialize privacy exporters on init hook.
#325
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
approved these changes
Sep 15, 2025
qasumitbagthariya
approved these changes
Oct 5, 2025
Collaborator
qasumitbagthariya
left a comment
qasumitbagthariya
left a comment
There was a problem hiding this comment.
QA Update ✅
I have verified this PR in the fix/PAYFAST-38-early-i18n-notice branch, which has been fixed and is functioning as intended.
I tested the following on this branch:
Before Fix:
After Fix:
Testing Environment
- WordPress: 6.8.3
- Theme: Twenty Twenty-Five 1.3
- WooCommerce - 10.2.2
- PHP: 8.0.30
- Web Server: Nginx 1.20.2
- Browser: Chrome
- OS: macOS 15.2
- Branch: fix/PAYFAST-38-early-i18n-notice
Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:
- Yes
- Not Required/Applicable for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Relocates the initialization of the privacy export class from the
plugin_loadedhook to thewoocommerce_inithook, which fires on the WordPressinithook.This is to prevent WordPress throwing a notice due to the early calling of
_load_textdomain_just_in_timevia the privacy constructor.Note
The plugin uses the domain
woocommerce-gateway-payfastwhile the slug on WordPress.org iswoocommerce-payfast-gateway. For the time being this is preventing the removal of theload_plugin_textdomaincall.In order to remove it, the domain will need to be updated to match the wp.org plugin slug. See the i18n docs.
Closes https://linear.app/a8c/issue/PAYFAST-38/php-notice-function-load-textdomain-just-in-time-was-called
Steps to test the changes in this Pull Request:
Changelog entry