Avoid running untrusted input as shell commands in the GitHub Actions#418
Merged
Conversation
martynmjones
approved these changes
May 9, 2024
martynmjones
left a comment
martynmjones
left a comment
Contributor
There was a problem hiding this comment.
Hey @eason9487, thanks for the changes.
I'm not seeing any other references so based on our discussion on Slack this PR LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR avoids running untrusted input as shell commands in the GitHub Actions.
Ref: https://securitylab.github.com/research/github-actions-untrusted-input/
Checks:
Detailed test instructions:
Please refer to the PR woocommerce/google-listings-and-ads#2394 that fixes the same issue.
Changelog entry