Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update react monorepo to v19 (major) #4529

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 8, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) ^18.3.1 -> ^19.0.0 age adoption passing confidence
react (source) ^18.3.1 -> ^19.0.0 age adoption passing confidence
react-dom (source) ^18.3.1 -> ^19.0.0 age adoption passing confidence

Release Notes

facebook/react (react)

v19.0.0

Compare Source

facebook/react (react-dom)

v19.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "* * * * 0,6" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Dec 8, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-4529.surge.sh

@qwerty287
Copy link
Contributor

@anbraten react 19 seems to be supported? Can we merge this?

@anbraten
Copy link
Member

anbraten commented Dec 8, 2024

It might work somehow, however peer dependencies are set to the following so I would avoid updating atm to stop it from throwing warnings.

"peerDependencies": {
    "@mdx-js/react": "^3.0.0",
    "react": "^18.0.0",
    "react-dom": "^18.0.0"
  },

@qwerty287
Copy link
Contributor

Which warnings do you mean? There are no in https://ci.woodpecker-ci.org/repos/3780/pipeline/23631/10

@renovate renovate bot changed the title chore(deps): update react monorepo to v19 (major) chore(deps): update react monorepo to v19 (major) - autoclosed Dec 8, 2024
@renovate renovate bot closed this Dec 8, 2024
@renovate renovate bot deleted the renovate/major-react-monorepo branch December 8, 2024 18:46
@renovate renovate bot changed the title chore(deps): update react monorepo to v19 (major) - autoclosed chore(deps): update react monorepo to v19 (major) Dec 8, 2024
@renovate renovate bot reopened this Dec 8, 2024
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from c2cccf8 to 447ea4a Compare December 8, 2024 18:52
@renovate renovate bot changed the title chore(deps): update react monorepo to v19 (major) fix(deps): update dependency react to v19 Dec 8, 2024
@renovate renovate bot changed the title fix(deps): update dependency react to v19 chore(deps): update react monorepo to v19 (major) Dec 8, 2024
@renovate renovate bot changed the title chore(deps): update react monorepo to v19 (major) fix(deps): update react monorepo to v19 (major) Dec 10, 2024
@qwerty287
Copy link
Contributor

@anbraten did you see my question?

Which warnings do you mean? There are no in https://ci.woodpecker-ci.org/repos/3780/pipeline/23631/10

@pat-s
Copy link
Contributor

pat-s commented Dec 11, 2024

I assume he means that these would throw warnings if the PR gets merged. However, I would expect the peer deps to be updated after that as well, no?

If we don't see any errors atm, I think we should trust our pipelines and checks and move on?

@anbraten
Copy link
Member

anbraten commented Dec 11, 2024

Any reason we need to push this update? The current React version is still supported. I guess we can just update when the docusaurus team is officially supporting it. At least it is throwing errors in the browser and warnings with pnpm install (doesn't happend in ci as of the frozen lockfile argument) with the new version and might be the reason of the broken search as well.

@pat-s
Copy link
Contributor

pat-s commented Dec 11, 2024

No need to push, it is just hanging around and people look at it then and try to resolve it.

As it is a major, it might very well cause issues. It is just important to not forget about it and reconsider it every once in a while once deps have caught up.

@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 447ea4a to 42d4037 Compare December 14, 2024 06:19
@anbraten anbraten marked this pull request as draft December 16, 2024 08:33
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 2 times, most recently from 7769e8e to 21dcca6 Compare December 24, 2024 10:12
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 21dcca6 to 7154ace Compare December 30, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants