-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update react monorepo to v19 (major) #4529
base: main
Are you sure you want to change the base?
Conversation
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-4529.surge.sh |
@anbraten react 19 seems to be supported? Can we merge this? |
It might work somehow, however peer dependencies are set to the following so I would avoid updating atm to stop it from throwing warnings.
|
Which warnings do you mean? There are no in https://ci.woodpecker-ci.org/repos/3780/pipeline/23631/10 |
c2cccf8
to
447ea4a
Compare
@anbraten did you see my question?
|
I assume he means that these would throw warnings if the PR gets merged. However, I would expect the peer deps to be updated after that as well, no? If we don't see any errors atm, I think we should trust our pipelines and checks and move on? |
Any reason we need to push this update? The current React version is still supported. I guess we can just update when the docusaurus team is officially supporting it. At least it is throwing errors in the browser and warnings with pnpm install (doesn't happend in ci as of the frozen lockfile argument) with the new version and might be the reason of the broken search as well. |
No need to push, it is just hanging around and people look at it then and try to resolve it. As it is a major, it might very well cause issues. It is just important to not forget about it and reconsider it every once in a while once deps have caught up. |
447ea4a
to
42d4037
Compare
7769e8e
to
21dcca6
Compare
21dcca6
to
7154ace
Compare
This PR contains the following updates:
^18.3.1
->^19.0.0
^18.3.1
->^19.0.0
^18.3.1
->^19.0.0
Release Notes
facebook/react (react)
v19.0.0
Compare Source
facebook/react (react-dom)
v19.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - "* * * * 0,6" (UTC), Automerge - "* 0-3 * * *" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.