Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Windi to Tailwind #4614

Merged
merged 60 commits into from
Jan 7, 2025
Merged

Migrate from Windi to Tailwind #4614

merged 60 commits into from
Jan 7, 2025

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Dec 23, 2024

superseedes #3279

fixes #2194

Had to add some scoped classes to resolve some padding and override clashes.
In addition, some width and height specifiers had to be changed as they are different between windi and tailwind.

@pat-s pat-s added refactor delete or replace old code build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Dec 23, 2024
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Dec 23, 2024

Deployment of preview was torn down

@pat-s pat-s force-pushed the refactor/windi-to-tailwind branch from 15912d6 to 6e64b94 Compare December 23, 2024 17:30
@pat-s pat-s marked this pull request as ready for review December 23, 2024 23:21
.yamllint.yaml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
web/src/views/admin/AdminRepos.vue Outdated Show resolved Hide resolved
web/vite.config.ts Show resolved Hide resolved
@pat-s
Copy link
Contributor Author

pat-s commented Jan 6, 2025

@xoxys Would be great if you could take a look at this and possibly investigate the "scoped classes" discussion yourself. Rebasing this with pnpm conflicts of main is somewhat of a pain and it would be great to get this merged in the near future.

@xoxys
Copy link
Member

xoxys commented Jan 6, 2025

Will try to look into it today.

@pat-s pat-s added this to the 3.0.0 milestone Jan 6, 2025
@xoxys
Copy link
Member

xoxys commented Jan 6, 2025

Alright, I made it through all files now. What a ride... Please also give it a final test.

@pat-s
Copy link
Contributor Author

pat-s commented Jan 6, 2025

Thanks! ❤️

Tried to tell you upfront that it wasn't so easy in my initial attempts 😅️

Looked through all pages again, couldn't spot anything, also checked the mobile view.

@xoxys xoxys requested a review from a team January 6, 2025 23:26
web/package.json Show resolved Hide resolved
web/package.json Show resolved Hide resolved
@pat-s pat-s merged commit 2d3db3d into main Jan 7, 2025
7 checks passed
@pat-s pat-s deleted the refactor/windi-to-tailwind branch January 7, 2025 07:52
@woodpecker-bot woodpecker-bot mentioned this pull request Jan 7, 2025
1 task
@qwerty287
Copy link
Contributor

@pat-s could you please explain why we have this textlint dependency? It seems to be a MD linter but it's unused?

@pat-s
Copy link
Contributor Author

pat-s commented Jan 8, 2025

I don't know, I can't remember having added this specifically (already stated this in the last comment). Maybe a dep of another linter?

Don't know if it's worth spending so much time on it. Feel free to remove it again if it bugs you.

@qwerty287
Copy link
Contributor

No, you added that explicitely in 798cd3c.

Nevermind, removed it in #4684

@pat-s
Copy link
Contributor Author

pat-s commented Jan 8, 2025

Ah then apologies, couldn't remember that (I think I made like 100+ commits in December).

@xoxys xoxys mentioned this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_pr_images If set, the CI will build images for this PR and push to Dockerhub refactor delete or replace old code ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to TailwindCSS
4 participants