-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Windi to Tailwind #4614
Conversation
Deployment of preview was torn down |
15912d6
to
6e64b94
Compare
@xoxys Would be great if you could take a look at this and possibly investigate the "scoped classes" discussion yourself. Rebasing this with pnpm conflicts of main is somewhat of a pain and it would be great to get this merged in the near future. |
Will try to look into it today. |
Alright, I made it through all files now. What a ride... Please also give it a final test. |
Thanks! ❤️ Tried to tell you upfront that it wasn't so easy in my initial attempts 😅️ Looked through all pages again, couldn't spot anything, also checked the mobile view. |
@pat-s could you please explain why we have this |
I don't know, I can't remember having added this specifically (already stated this in the last comment). Maybe a dep of another linter? Don't know if it's worth spending so much time on it. Feel free to remove it again if it bugs you. |
Ah then apologies, couldn't remember that (I think I made like 100+ commits in December). |
superseedes #3279
fixes #2194
Had to add some scoped classes to resolve some padding and override clashes.
In addition, some width and height specifiers had to be changed as they are different between windi and tailwind.