-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework pipeline messages #4626
base: main
Are you sure you want to change the base?
Rework pipeline messages #4626
Conversation
@qwerty287 Why is that breaking? Because of the env var change? |
Yes, env var change and it also changes the json for the pipeline model |
Deploying preview to https://woodpecker-ci-woodpecker-pr-4626.surge.sh |
@woodpecker-ci/maintainers somebody has an idea how to fix the DB tests? https://ci.woodpecker-ci.org/repos/3780/pipeline/24869/38 Besides that, this PR can get first reviews. It still needs testing and the UI is probably not the best. Also, there are some todos, especially in the bitbucket code. Maybe @langecode you can check this out? |
Can you add a bit more context about what has changed and how it fixes the linked issue? IMO it helps to provide a more detailed PR description in addition to the code. |
@xoxys updated the description |
Thank you! ❤️ |
supersedes #3421
closes #2971
Currently, our pipeline model has fields like the message, title etc., but every field is used differently, dependending on the event.
This PR changes this and splits these reused fields to have a more clear pipeline model.
The model now has fields like:
and similar.
Advantages:
Especially 3 and 4 and are the enhancement parts here, as we can now store both context and commit message and not only one.
TODO