Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workflow-level volumes and networks #4636

Merged
merged 6 commits into from
Dec 30, 2024

Conversation

qwerty287
Copy link
Contributor

Undocumented and unusable because the yaml values were not passed through.

@qwerty287 qwerty287 added the refactor delete or replace old code label Dec 28, 2024
@qwerty287 qwerty287 requested a review from a team December 28, 2024 09:30
@pat-s
Copy link
Contributor

pat-s commented Dec 29, 2024

Fine for me in general if unused, but there there ever an idea behind it? Maybe checking with the person who put it there (git blame) just to make sure we don't overlook anything?

@qwerty287
Copy link
Contributor Author

It was already present in drone...

@pat-s pat-s enabled auto-merge (squash) December 29, 2024 14:41
@qwerty287 qwerty287 requested a review from pat-s December 30, 2024 07:07
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 28.17%. Comparing base (afa6dee) to head (a5e2bbb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/backend/docker/docker.go 0.00% 15 Missing ⚠️
pipeline/backend/kubernetes/kubernetes.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4636      +/-   ##
==========================================
- Coverage   28.22%   28.17%   -0.05%     
==========================================
  Files         400      398       -2     
  Lines       28232    28193      -39     
==========================================
- Hits         7969     7944      -25     
+ Misses      19557    19543      -14     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-s pat-s merged commit 428ba68 into woodpecker-ci:main Dec 30, 2024
7 of 9 checks passed
@woodpecker-bot
Copy link
Collaborator

@woodpecker-bot woodpecker-bot mentioned this pull request Dec 30, 2024
1 task
@qwerty287 qwerty287 deleted the native-vol branch December 30, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants