Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority menu to tabs #4641

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add priority menu to tabs #4641

wants to merge 5 commits into from

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Dec 29, 2024

Supersedes: #4610

Adds a priority plus menu to tabs that contains all tabs items that don't fix into the available screen size. The wordwrap issue seen in one of the demo videos was fixed already.

Bildschirmaufzeichnung.vom.2024-12-29.15-07-34.mp4
Bildschirmaufzeichnung.vom.2024-12-29.15-07-57.mp4

@xoxys xoxys added ui frontend related refactor delete or replace old code labels Dec 29, 2024
@pat-s
Copy link
Contributor

pat-s commented Dec 29, 2024

I agree this is a better one, thanks for putting the effort in.

Can we use horizontal dots instead of vertical ones? This should also be the common default for other sites.

@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

Sure I can but without a border around the button and beside text this variant looks better IMO. And a lot of mobile apps use vertical docs e.g. GitHub, Firefox, Mastodon

@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

@pat-s you would still prefer horizontal dots?

@pat-s
Copy link
Contributor

pat-s commented Dec 29, 2024

I can also live with vertical ones if you have a strong preference for it.

Yet this is what I see on iPhone 15 (safari) with default settings:

image

This is caused if the language is "german" as the "pipeline ausführen" button is then too large and collapses everything on the left. The dots then expand to the left and leave the screen.

Would it be complicated to enforce showing at least one item at all times? This would then avoid the menu issue going out of bounds and improve the overall feel.

@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

Good catch, will fix that case.

@xoxys xoxys requested a review from a team December 29, 2024 22:29
@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

@anbraten as your javascript knowledge is way better than mine your feedback would be very welcome.

@pat-s
Copy link
Contributor

pat-s commented Dec 30, 2024

@xoxys Do you want to wait here until @anbraten replied?

@xoxys
Copy link
Member Author

xoxys commented Dec 30, 2024

No we can proceed IMO. Can be improved later as well if there is any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants