-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priority menu to tabs #4641
base: main
Are you sure you want to change the base?
Conversation
I agree this is a better one, thanks for putting the effort in. Can we use horizontal dots instead of vertical ones? This should also be the common default for other sites. |
Sure I can but without a border around the button and beside text this variant looks better IMO. And a lot of mobile apps use vertical docs e.g. GitHub, Firefox, Mastodon |
@pat-s you would still prefer horizontal dots? |
I can also live with vertical ones if you have a strong preference for it. Yet this is what I see on iPhone 15 (safari) with default settings: This is caused if the language is "german" as the "pipeline ausführen" button is then too large and collapses everything on the left. The dots then expand to the left and leave the screen. Would it be complicated to enforce showing at least one item at all times? This would then avoid the menu issue going out of bounds and improve the overall feel. |
Good catch, will fix that case. |
@anbraten as your javascript knowledge is way better than mine your feedback would be very welcome. |
No we can proceed IMO. Can be improved later as well if there is any feedback. |
Supersedes: #4610
Adds a priority plus menu to tabs that contains all tabs items that don't fix into the available screen size. The wordwrap issue seen in one of the demo videos was fixed already.
Bildschirmaufzeichnung.vom.2024-12-29.15-07-34.mp4
Bildschirmaufzeichnung.vom.2024-12-29.15-07-57.mp4