-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(member): move github username from assignment to member #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"휴대전화 번호" 키워드가 프론트엔드 영역에서 변경된 것을 확인하였습니다 🙂
회원가입/로그인까지 시도해봤는데 동작에 이상 없는 것을 확인했습니다!
미리 챙겨주셔서 감사합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 보는 사이 머지되었군요,,
로컬에서 확인 시 이상 없었습니다!
@@ -242,6 +242,7 @@ class DatabaseInitializer( | |||
email = "[email protected]", | |||
phoneNumber = "010-0000-0000", | |||
gender = Gender.MALE, | |||
githubUsername = "jaeyeonling", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋㅋㅋ
Resolves #744, resolves #752
해결하려는 문제가 무엇인가요?
전화번호
,휴대폰 번호
,휴대전화 번호
중휴대전화 번호
로 표현을 통일한다.어떻게 해결했나요?
어떤 부분에 집중하여 리뷰해야 할까요?
참고 자료
RCA 룰
r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)