feat(member): remove gender #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woowahan-pjs
requested review from
woowahan-neo,
woowabrie,
woowahan-leah and
woowahan-cron
woowahan-cron
approved these changes
May 16, 2024
Comment on lines
+2
to
+3
| export * from "./members"; | ||
| export * from "./recruitments"; |
woowabrie
approved these changes
May 17, 2024
| birthday = createLocalDate(2020, 1, 1), | ||
| password = Password("password") | ||
| password = Password("password"), |
There was a problem hiding this comment.
코틀린의 버전이 특정 버전 이상이 되면 Ktlint에서 이를 기본 코딩 규칙으로 사용하더라고요. 미리 사용해 보고 있어요!
https://kotlinlang.org/docs/coding-conventions.html#trailing-commas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #739
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?
어떤 부분에 집중하여 리뷰해야 할까요?
참고 자료
RCA 룰
r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)