-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5기] 4주차 쇼핑몰 과제 제출 - 얄뭉 #7
Open
yeojiin
wants to merge
64
commits into
woowahan-pjs:main
Choose a base branch
from
yeojiin:yeojiin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
커머스 구조는 간단하게 가져가고 기본 요구 사항만 맞추는 방향으로 진행했습니다.
이번엔 소스를 구현하는 것보다 테스트 케이스를 작성하는 데 더 신경을 썼습니다!
평소에 테스트 케이스를 많이 작성하지 않다보니 어려움이 있었지만, 도전적으로 작성했다고 생각합니다!
구현을 하면서 어디까지 구현 하는가? 에 대해 고민을 많이 했는데 점차 더 리펙토링할 기회가 생길 것 같아
다음에는 인터페이스 등을 활용해보는 방향으로 리펙토링하면 어떨까 싶습니다.
그리고 테스트 케이스도 좀 더 확장해서 단순히 하나의 controller를 테스트하지 않고, 이어지는 행동들을 테스트하는 식으로 발전시키면 좋을 것 같습니다.
이번 과제도 생각할 점이 많고, 스스로 성장할 수 있는 좋은 과제였습니다!
좀 더 발전시켜보겠습니다!😚