Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch threads when necessary when pre-processing html #1101

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Switch threads when necessary when pre-processing html #1101

merged 1 commit into from
Mar 12, 2025
+16 −2

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Mar 11, 2025 •
edited
Loading

Fix

Since HTML parsing can be performed from BG thread, we need to make sure we execute code that handles views on main thread.

Make sure placeholders are displayed correctly.

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

Sorry, something went wrong.

@khaykov khaykov requested review from planarvoid and danilo04 March 11, 2025 18:49
planarvoid
planarvoid approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@planarvoid planarvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍

@khaykov khaykov merged commit 329c368 into trunk Mar 12, 2025
14 checks passed
@khaykov khaykov deleted the issue/implement-thread-switching-when-parsing-html branch March 12, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planarvoid planarvoid

@danilo04 danilo04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khaykov @planarvoid