Add touch event handling in AztecText when field is disabled #1102
+73
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @danilo04 ! It appears to be working as expected, but since this changes default behavior, I think we need to put behind an opt-in flag. |
|
@khaykov Added flag for tap on links when aztec text is disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
When the
AztecTextis disabled (isEnabled = false), touch events aren't handled byEnhancedMovementMethod.onTouchEvent. In this PR, we handle touch events for links inAztectext.onTouchEventis it is disabled. Since touch events at this level are executed, we can reuse the same logic inEnhancedMovementMethodto handle touch events on links.Test
Review
@khaykov
Make sure strings will be translated:
strings.xmlas a part of the integration PR.