Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Oct 27, 2025

What?

How?

Switch to SVGView, which is a more modern framework, and as lenient as a browser when it comes to parsing SVG. It supports shorten coordinates like 5.5h3a.5.5 that are common in Gutenberg.

One of the design choices was to enforce a particular fill color (in order to support dark mode). It works great for nearly all icons, but I found only one exception so far – "Animoto Embed". This icon uses multiple colors, and doesn't look ideal (see screenshots below). We can simply hardcode a different icon for it if we want. Note: you need to merge #204 to test the embed variants.

Testing Instructions

  • Verify that no blocks display placeholder icons
  • Verify that icons work in dark mode

Screenshots or screencast

Screenshot 2025-10-27 at 6 21 21 PM Screenshot 2025-10-27 at 6 21 27 PM

Known Issues (Identified in the scope of this PR)

(these are fixed by #199)

Screenshots (core/embed variants)

Before:

Screenshot 2025-10-27 at 4 21 24 PM

After:
Screenshot 2025-10-27 at 6 26 02 PM Screenshot 2025-10-27 at 6 26 04 PM

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound overall. I welcome @jkmassel 's feedback on the inclusion of SVGView.

Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound overall. I welcome @jkmassel 's feedback on the inclusion of SVGView.

I'm not a big fan of it overall, but I think it works and it moves us forward for now. We can revisit this one later when we're implementing this on the Android side.

@kean kean enabled auto-merge (squash) October 29, 2025 19:30
@kean kean merged commit 9e94f49 into trunk Oct 29, 2025
11 checks passed
@kean kean deleted the task/svgview branch October 29, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants