Skip to content

Update upload service to use work manager#19755

Closed
ravishanker wants to merge 3 commits intotrunkfrom
Update-UploadService-to-Kotlin,-and-use-WorkManager
Closed

Update upload service to use work manager#19755
ravishanker wants to merge 3 commits intotrunkfrom
Update-UploadService-to-Kotlin,-and-use-WorkManager

Conversation

@ravishanker
Copy link
Copy Markdown
Contributor

Fixes #18714

This PR is an effort update UploadService to user WorkManager in place of current Service. Cause, there are crashes due to foreground operations, and also will not work when migrated to Android 14

It is work in progress

  • UploadService is decomposed into two workers; UploadPostWorker, and UploadMediaWorker

TO-DO

  • Integrate this wherever UploadService is used
  • Test it thoroughly all Post, and Media upload scenarios
  • Delete UploadService

To Test:


Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Decompose UploadService to use WorkManager in place of Service
Decompose UploadService to use WorkManager in place of Service
For
- UploadPostWorker
- UploadMediaWorker
@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Copy Markdown
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19755-8e38e4a
Commit8e38e4a
Direct Downloadjetpack-prototype-build-pr19755-8e38e4a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19755-8e38e4a
Commit8e38e4a
Direct Downloadwordpress-prototype-build-pr19755-8e38e4a.apk
Note: Google Login is not supported on these builds.

@oguzkocer
Copy link
Copy Markdown
Contributor

We are slowly stepping away from FluxC which this PR depends, and considering the PR hasn't been updated in a long time, I think it's best to close and re-visit if necessary.

@oguzkocer oguzkocer closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuntimeException: Unable to start service org.wordpress.android.ui.uploads.UploadService@a38ce00 with Intent { cmp=...

3 participants