Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gravatar_quick_editor feature flag setup #21552

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

AdamGrzybkowski
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski commented Dec 23, 2024

The configuration of the GravatarQuickEditorFeatureConfig was wrong and it always resolved to true even when the remote flag was set to false.

I misunderstood how this system works in the Jetpack app and that the build config value always overrides the remote one.

This is now fixed.


To Test:

  1. Run the app fro this PR
  2. Tap on the Me in the bottom bar
  3. Tap the avatar in the top left
  4. Confirm a Gravatar QuickEditor is shown
  5. Open versions.properties in AS and change versionName to 25.4
  6. Repeat steps 1-3
  7. Confirm a new screen titled Choose photo was shown and not the QuickEditor

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@AdamGrzybkowski AdamGrzybkowski added the Gravatar Gravatar integration label Dec 23, 2024
@AdamGrzybkowski AdamGrzybkowski added this to the 25.6 ❄️ milestone Dec 23, 2024
@AdamGrzybkowski AdamGrzybkowski requested review from a team and nbradbury and removed request for a team December 23, 2024 08:11
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21552-0cff7cc
Commit0cff7cc
Direct Downloadjetpack-prototype-build-pr21552-0cff7cc.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21552-0cff7cc
Commit0cff7cc
Direct Downloadwordpress-prototype-build-pr21552-0cff7cc.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.48%. Comparing base (194cad2) to head (0cff7cc).
Report is 21 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21552   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files        2117     2117           
  Lines       99464    99464           
  Branches    15296    15296           
=======================================
  Hits        39269    39269           
  Misses      56714    56714           
  Partials     3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamGrzybkowski Apologies for the delay on this - I was AFK for the holidays. This all works as expected so feel free to merge when ready! :shipit:

@nbradbury nbradbury self-assigned this Jan 3, 2025
@AdamGrzybkowski AdamGrzybkowski merged commit e8c3b08 into trunk Jan 7, 2025
24 of 26 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the adam/quick_editor_feature_flag_fix branch January 7, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gravatar Gravatar integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants