Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LocaleManager.getSafeLocale #21560

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Jan 3, 2025

This PR removes getSafeLocale() from LocaleManager. That code was added as a workaround for a bug in Android 7, but we no longer support that version so the function was unnecessary.

Passing CI should be sufficient to approve this.

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 3, 2025

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented Jan 3, 2025

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21560-5c9abf7
Commit5c9abf7
Direct Downloadjetpack-prototype-build-pr21560-5c9abf7.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21560-5c9abf7
Commit5c9abf7
Direct Downloadwordpress-prototype-build-pr21560-5c9abf7.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 39.35%. Comparing base (75feb2e) to head (5c9abf7).
Report is 2 commits behind head on trunk.

Files with missing lines Patch % Lines
...java/org/wordpress/android/ui/posts/PostUtils.java 0.00% 5 Missing ⚠️
...wordpress/android/ui/reader/utils/ReaderUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #21560      +/-   ##
==========================================
- Coverage   39.48%   39.35%   -0.13%     
==========================================
  Files        2117     2108       -9     
  Lines       99464    99107     -357     
  Branches    15296    15258      -38     
==========================================
- Hits        39269    39002     -267     
+ Misses      56714    56638      -76     
+ Partials     3481     3467      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury requested review from ParaskP7 and dcalhoun January 3, 2025 19:47
@nbradbury nbradbury marked this pull request as ready for review January 3, 2025 19:49
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me, thanks for cleaning up. For posterity, the workaround introduction and explanation appear to be in #7413.

Passing CI should be sufficient to approve this.

CI appears to be passing. 🎉

@nbradbury nbradbury merged commit 9589a3f into trunk Jan 6, 2025
25 checks passed
@nbradbury nbradbury deleted the issue/remove-get-safe-locale branch January 6, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants