-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LocaleManager.getSafeLocale #21560
Conversation
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21560 +/- ##
==========================================
- Coverage 39.48% 39.35% -0.13%
==========================================
Files 2117 2108 -9
Lines 99464 99107 -357
Branches 15296 15258 -38
==========================================
- Hits 39269 39002 -267
+ Misses 56714 56638 -76
+ Partials 3481 3467 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me, thanks for cleaning up. For posterity, the workaround introduction and explanation appear to be in #7413.
Passing CI should be sufficient to approve this.
CI appears to be passing. 🎉
This PR removes
getSafeLocale()
fromLocaleManager
. That code was added as a workaround for a bug in Android 7, but we no longer support that version so the function was unnecessary.Passing CI should be sufficient to approve this.