issue/34-refactor-mediapickerviewmodel #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # MediaPicker/src/main/res/values/colors.xml # MediaPicker/src/main/res/values/strings.xml
Merged
wzieba
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Looks good, thanks @anitaa1990!
Yeah, there's a lot of references to FluxC in view models. I hope that we'll refactor it to state where there will be no any mention of WordPress-specific API in the whole presentation layer of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially works on #34 by cleaning up the
MediaPickerViewModelclass.Changes
SiteModel,MediaModelandMediaStorefrom the class.MimeTypeSupportProvider.LiveDataUtils,PermissionsHandler,ResourceProvider,Eventand supported strings.The idea is to first clean up the classes so that the library can build and then work on improving the code base, similar to @wzieba's work on creating modules in #47