Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg Comments #24063

Open
wants to merge 71 commits into
base: trunk
Choose a base branch
from
Open

Gutenberg Comments #24063

wants to merge 71 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Feb 11, 2025

This is a feature branch for Gutenberg Comments. It contains a set of changes to fully switch to WebKit-based rendering for comments.

Changes:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 11, 2025

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 11, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24063-71f6808
Version25.7.1
Bundle IDorg.wordpress.alpha
Commit71f6808
App Center BuildWPiOS - One-Offs #11483
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 11, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24063-71f6808
Version25.7.1
Bundle IDcom.jetpack.alpha
Commit71f6808
App Center Buildjetpack-installable-builds #10515
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added the Comments label Feb 11, 2025
@kean kean added this to the 25.8 milestone Feb 11, 2025
@kean kean requested a review from crazytonyli February 11, 2025 20:23
@kean kean marked this pull request as ready for review February 11, 2025 20:23
@kean
Copy link
Contributor Author

kean commented Feb 12, 2025

Hey, @crazytonyli, the PRs in this feature branch have been reviews except for the first two. I'd appreciate if you could go over the changes to see if there is anything catches your eye. It should be in a good shape now, and I'll make a few more improvements tomorrow before I head for AFK.

@crazytonyli
Copy link
Contributor

@kean They all look good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants