-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg Comments #24063
Open
kean
wants to merge
71
commits into
trunk
Choose a base branch
from
feature/gutenberg-comments
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gutenberg Comments #24063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24063-71f6808 | |
Version | 25.7.1 | |
Bundle ID | org.wordpress.alpha | |
Commit | 71f6808 | |
App Center Build | WPiOS - One-Offs #11483 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24063-71f6808 | |
Version | 25.7.1 | |
Bundle ID | com.jetpack.alpha | |
Commit | 71f6808 | |
App Center Build | jetpack-installable-builds #10515 |
Hey, @crazytonyli, the PRs in this feature branch have been reviews except for the first two. I'd appreciate if you could go over the changes to see if there is anything catches your eye. It should be in a good shape now, and I'll make a few more improvements tomorrow before I head for AFK. |
@kean They all look good to me 👍 |
crazytonyli
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature branch for Gutenberg Comments. It contains a set of changes to fully switch to WebKit-based rendering for comments.
Changes:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: