Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate GBK in Comment Composer #24071

Open
wants to merge 5 commits into
base: feature/gutenberg-comments
Choose a base branch
from

Conversation

kean
Copy link
Contributor

@kean kean commented Feb 12, 2025

This PR adds an initial implementation of the Gutenberg-based Comment Composer. The change is incomplete, which is why it's hidden under the feature flag.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-12.at.10.50.21.mp4

To test:

  • Enable the "Gutenberg Comment Composer" FF
  • Verify that you can publish basic Gutenberg comments to a site that supports it. Note: there is currently no logic that determines which sites are supported, so it's enabled for all sites.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 12, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24071-4893b18
Version25.7.1
Bundle IDorg.wordpress.alpha
Commit4893b18
App Center BuildWPiOS - One-Offs #11481
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 12, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24071-4893b18
Version25.7.1
Bundle IDcom.jetpack.alpha
Commit4893b18
App Center Buildjetpack-installable-builds #10513
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added the Comments label Feb 12, 2025
@kean kean force-pushed the task/gutenberg-editor branch from 56ed19f to 4893b18 Compare February 12, 2025 18:42
@kean kean requested a review from crazytonyli February 12, 2025 18:43
@kean kean marked this pull request as ready for review February 12, 2025 18:44
Base automatically changed from task/final-webkit-comments-tweaks to feature/gutenberg-comments February 12, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants