-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ImmuTable
to dedicated package
#24152
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24152-d4441a7 | |
Version | 25.7.1 | |
Bundle ID | org.wordpress.alpha | |
Commit | d4441a7 | |
App Center Build | WPiOS - One-Offs #11588 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24152-d4441a7 | |
Version | 25.7.1 | |
Bundle ID | com.jetpack.alpha | |
Commit | d4441a7 | |
App Center Build | jetpack-installable-builds #10618 |
It was easier than identifying the access control relationships, change them for the purpose of moving the files, then updating once the move was completed.
I run the extraction building the Jetpack target which clearly misses some of the tests.
FYI @kean @crazytonyli I started this when first looking into this round of modularization but then paused it for the Core Data stuff. I don't consider it urgent but wanted to let you know about it in case you end up touching the |
Oh looks like I removed some of the code that was using it. We don't really use this type anymore. For forms, we stick with SwiftUI. |
|
I'll see whether to continue with this or drop once done with #24165 |
I was looking around the codebase and saw what looked like a quick win for modularization: move the
ImmuTable
implementation in a dedicated package.This is just a little step forward towards more modularization and less time spend compiling.
WordPressUI could have been another destination for the logic. If you feel it's better to move it there, I'll follow up with a dedicated PR. The bulk of the work was to move it out of the main target anyway
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: