-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support WordPress.com magic link login #24260
base: trunk
Are you sure you want to change the base?
Conversation
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24260-04cd083 | |
Version | 25.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | 04cd083 | |
App Center Build | WPiOS - One-Offs #11775 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24260-04cd083 | |
Version | 25.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | 04cd083 | |
App Center Build | jetpack-installable-builds #10801 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Tony, thanks for working on this issue, because I encountered the same issue few days ago.
While testing this PR, I encountered a blocking issue. If you follow these steps, you will not be able to log in with the magic link:
- I created a new account in the app and logged in automatically.
- I logged out (also in the webview).
- I attempted to log in again.
- I reached the view where I was asked to receive the magic link and pressed the button to receive the email.
- I received the email and copy-pasted the link into Safari within the simulator.
- I logged into the webview, then I was redirected to the app using the deeplink.
- I got stuck on the previous view that asked me to check my email, and after closing it, I remained unauthenticated.

ef5ca1f
to
04cd083
Compare
@pmusolino Good catch! That bug slipped through after a code refactor. I have fixed the issue and have added an unit test to cover logging in via login links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Tony, now it works as expected!
I just found an additional issue. Since you have more knowledge than me in login, I'm not sure it's strictly related to this PR, and it's probably how the magic link is handled on the web. Basically, if I'm already logged in on the browser (Safari), the magic link doesn't work and does not redirect me to the app, making it impossible to log in properly in the app. Wdyt?
Fixes #24171.
This PR implements the option 1 in issue #24171.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: