Implement CMM-739: Generate post excerpt #24852

kean · 2025-09-16T19:06:33Z

Fixes https://linear.app/a8c/issue/CMM-739/generate-post-excerpt

Recording

generate-excerpt.mov

Screenshots (iPhone)

Screenshots (Negative Scenarios)

Simulator.Screen.Recording.-.iPhone.17.-.2025-09-17.at.06.54.12.mov

Screenshots (iPad)

dangermattic · 2025-09-16T19:07:21Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2025-09-16T19:50:32Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`29091`
	Version	`PR #24852`
	Bundle ID	`com.jetpack.alpha`
	Commit	`5beb232`
	Installation URL	2fbp30gimpao8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2025-09-16T19:50:42Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`29091`
	Version	`PR #24852`
	Bundle ID	`org.wordpress.alpha`
	Commit	`5beb232`
	Installation URL	5q2mk8tjue07o

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

crazytonyli · 2025-09-18T01:03:40Z

.../Classes/ViewRelated/Post/PostSettings/Views/Excerpt/PostSettingsGenerateExcerptButton.swift

+            HStack(spacing: 4) {
+                Image(systemName: "sparkle")
+                    .font(.caption2)
+                Text(Strings.generateButton)


I wonder if this "Generate" label is needed. The icon would probably be enough?

crazytonyli · 2025-09-18T01:06:29Z

Modules/Sources/WordPressShared/Utility/LanguageModelHelper.swift

@@ -0,0 +1,128 @@
+import Foundation
+
+#if canImport(FoundationModels)


The canImport checks can be removed.

Claude added it for some reason and I kept it – removed.

crazytonyli · 2025-09-18T01:19:33Z

...ss/Classes/ViewRelated/Post/PostSettings/Views/Excerpt/PostSettingsGenerateExcerptView.swift

+    private func startGeneration() async throws {
+        let session = LanguageModelSession()
+        let prompt = LanguageModelHelper.makeGenerateExcerptPrompt(
+            content: postContent,


Is it possible to use one single LanguageModelSession, with postContent (which won't be changed during the session) loaded into it? I think that should speed up the generation process, because it does not need to process the same postContent again and again in the startGeneration function.

My understanding is LanguageModelSession should be reused only if you want to keep context between interactions. I don't think this is what you want when changing the criteria. I did just add a "Suggest More Options" button to generate more results where I reuse LanguageModelSession. From my testing, even running a simple prompt like "generate more results" in the same session still takes roughly the same amount of time as starting a new session.

excerpt-load-more.mov

crazytonyli · 2025-09-18T01:22:02Z

...ss/Classes/ViewRelated/Post/PostSettings/Views/Excerpt/PostSettingsGenerateExcerptView.swift

+        case loading
+        case error
+        case finished
+    }


Can this be removed?

Sure. I used it when iterating on the design of cells. I don't think we'll need it anymore – removed.

crazytonyli · 2025-09-18T01:23:18Z

...ss/Classes/ViewRelated/Post/PostSettings/Views/Excerpt/PostSettingsGenerateExcerptView.swift

+
+                        Image(systemName: "chevron.right")
+                            .font(.caption2.weight(.semibold))
+                            .foregroundStyle(Color(.secondaryLabel).opacity(0.5))


This chevron makes me think there is a details view upon tapping it. Can it be removed?

I wanted to show that it's tappable, but I agree I think it adds more confusion than anything else. You'll figure out that you just need to tap on one of the options. Removed.

crazytonyli · 2025-09-18T01:27:36Z

WordPress/Classes/ViewRelated/Post/PostSettings/Views/Excerpt/PostSettingsExcerptEditor.swift

+        .navigationBarTitleDisplayMode(.inline)
+        .toolbar {
+            ToolbarItem(placement: .topBarTrailing) {
+                if !postContent.isEmpty && LanguageModelHelper.isSupported {


The generated result is not great when the post content is short. The result is heavily influenced by the prompt, rather than the "source content". Maybe we should only show the "Generate" button when the post content is at least a certain characters long?

I opened a bug https://linear.app/a8c/issue/CMM-763/if-the-post-content-is-too-short-the-results-are-not-helpful. I tried to program the model itself to do that, but it ignores this instruction.

I was thinking do an if (postContent.length > 1000) { useLLM() } check.

crazytonyli · 2025-09-18T01:29:18Z

Modules/Sources/WordPressShared/Utility/LanguageModelHelper.swift

+        • Include the post's main value proposition
+        • Use active voice (avoid "is", "are", "was", "were" when possible)
+        • End with implicit promise of more information
+        • Do not use ellipsis (...) at the end


The generated result is English when the content is non-English. Adding a requirement here saying that the excerpt should be in the same language as the source content?

I wasn't going to test different locales but ran out of time.

If the post content is not supported, it will show this:

I can't get it to produce the results in anything other than English. I opened a ticket –https://linear.app/a8c/issue/CMM-762/excerpts-are-created-in-the-system-language-not-the-content-language. Help is welcome.

crazytonyli · 2025-09-18T01:32:49Z

Modules/Sources/WordPressShared/Utility/LanguageModelHelper.swift

+        Excerpt 3: Lead with the primary benefit or outcome
+
+        SOURCE CONTENT:
+        \(content)


The content is in HTML format. That does not seem to bother the LLM, because the result is pretty on point. But I wonder if we should still explicitly mention that the source content is in HTML format in the prompt.

I initially wanted to trim HTML, but I wasn't sure it'll work well with Gutenberg blocks. Ideally, we want a rendered version of the post, but we don't have that. Based on my testing, it just figures it out, so I think we are good.

sonarqubecloud · 2025-09-19T18:13:34Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kean added this to the 26.4 milestone Sep 16, 2025

kean force-pushed the task/add-excerpt-generation branch 2 times, most recently from 3f05821 to f60e252 Compare September 16, 2025 19:17

kean requested a review from crazytonyli September 16, 2025 19:27

kean added the Intelligence label Sep 16, 2025

kean force-pushed the task/add-excerpt-generation branch 2 times, most recently from 377fde8 to 31362a1 Compare September 16, 2025 19:38

kean force-pushed the task/add-excerpt-generation branch from d00970f to dce58de Compare September 17, 2025 11:49

kean added 7 commits September 17, 2025 07:51

Implement CMM-739: Generate post excerpt

f955c5d

Simplify debounce

459b548

Improve prompts

405909b

Fix open settings

560c62f

Fix iPad presentation

e568066

Add analytics

a0a852c

Add analytics

6011562

kean force-pushed the task/add-excerpt-generation branch from dce58de to 6011562 Compare September 17, 2025 11:52

crazytonyli reviewed Sep 18, 2025

View reviewed changes

kean added 9 commits September 18, 2025 06:07

Remove redundant canImport

d740fbd

Extract generateExcerptInstructions

bc1b7a9

Add show more button

fd252ad

Remove TestsScenario

67a8e07

Remove chevron

dec2b53

Remove test scenarios

24ab67c

Fix isGenerating not resettting

1c643f0

Fix error not shown

f5ed66b

Add better error messags

7918244

Enable permissiveContentTransformations

821d52b

kean requested a review from crazytonyli September 18, 2025 12:44

Fix release build

c8c149f

kean enabled auto-merge September 19, 2025 18:10

Merge branch 'trunk' into task/add-excerpt-generation

5beb232

		@@ -0,0 +1,128 @@
		import Foundation

		#if canImport(FoundationModels)

Implement CMM-739: Generate post excerpt #24852

Are you sure you want to change the base?

Implement CMM-739: Generate post excerpt #24852

Uh oh!

Conversation

kean commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Recording

Screenshots (iPhone)

Screenshots (Negative Scenarios)

Screenshots (iPad)

Uh oh!

dangermattic commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazytonyli Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 19, 2025

Quality Gate passed

Uh oh!

Uh oh!

kean commented Sep 16, 2025 •

edited

Loading

dangermattic commented Sep 16, 2025 •

edited

Loading

wpmobilebot commented Sep 16, 2025 •

edited

Loading

wpmobilebot commented Sep 16, 2025 •

edited

Loading

crazytonyli Sep 18, 2025 •

edited

Loading